Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370148 - Commit entries on git-log page are not links
Summary: Commit entries on git-log page are not links
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 13:15 EST by Mark Macdonald CLA
Modified: 2012-02-01 08:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-01-30 13:15:10 EST 
Orion I20120130-1209

1. Go to the git-log page.
2. Mouseover a commit to show the commit info tooltip.
3. Tooltip shows the commit ID, but it's not a link.

The parent commit is a link, but not the current commit.
Comment 1 Mark Macdonald CLA 2012-01-30 17:40:18 EST 
OK, the root of the problem isn't the tooltip, it's that the commmits in the log are sometimes not real links, so the tooltip is all you get. This problem only seems to happen on local branches.

With that in mind, here are updated steps:

0. Create a new local branch.
1. Go to the git-log page for the branch.
2. Click on one of the commits.
3. Nothing happens. I expected to be taken to the commit details page.

If you try the same steps on master (or another remote branch), the commits are real links and can be clicked to go to the commit details.
Comment 2 Szymon Brandys CLA 2012-01-31 05:49:22 EST 
Breadcrumb for the git-log page is wrong and removes hrefs from all links on the page.
Comment 3 Malgorzata Janczarska CLA 2012-02-01 08:00:30 EST 
(In reply to comment #2)
> Breadcrumb for the git-log page is wrong and removes hrefs from all links on the
> page.
This was deliberately, previously we had links to diffs, but our compare editor couldn't show diffs for directories, to when we where displaying a directory we where removing the links. Now when we changed links to commit details I removed this walkaround.