Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370147 - wrong slf4j 1.6.4 classes
Summary: wrong slf4j 1.6.4 classes
Status: VERIFIED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: Juno M6   Edit
Assignee: Gunnar Wagenknecht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 338252
  Show dependency tree
 
Reported: 2012-01-30 12:47 EST by Igor Fedorenko CLA
Modified: 2012-01-31 01:56 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Fedorenko CLA 2012-01-30 12:47:52 EST 
slf4j.api 1.6.4 available from Orbit S20120123151124 [1] appears to contain classes from earlier an slf4j version.

For example, org/slf4j/LoggerFactory.class file size in the official spf4j-api jar from slf4j.org is 7932 bytes. Orbit bundle, on the other hand, has LoggerFactory.class file size 7530, which matches official 1.6.1 version. 

I also confirmed that Orbit slf4j 1.6.4 still contains http://bugzilla.slf4j.org/show_bug.cgi?id=228 , which was fixed in slf4j 1.6.2.


[1] http://download.eclipse.org/tools/orbit/downloads/drops/S20120123151124/
Comment 1 Gunnar Wagenknecht CLA 2012-01-30 16:01:48 EST 
This is weird. I verified the latest content from CVS branch using WinMerge and it did show changes. I updated the class files but no matter what I do the Eclipse CVS client don't show them as changed. Let my try a fresh checkout.
Comment 2 Gunnar Wagenknecht CLA 2012-01-30 16:21:24 EST 
I re-committed the class files and re-tagged the SLF4J bundles. I also made sure that no CVS keyword replacement is done for the attached source bundles. Igor, can you verify using the next build?
Comment 3 Igor Fedorenko CLA 2012-01-30 16:27:43 EST 
Is this the right place to look for a new build

http://download.eclipse.org/tools/orbit/downloads/

?
Comment 4 David Williams CLA 2012-01-30 16:34:15 EST 
(In reply to comment #3)
> Is this the right place to look for a new build
> 
> http://download.eclipse.org/tools/orbit/downloads/
> 
> ?

Best place to look first, is 
http://build.eclipse.org/orbit/committers/

That's where "just built" stuff goes before we promote it to "downloads". 

That assumes you can verify by looking at or using that one jar. 

(If you need it "in a build" then, you can request a promotion to "downloads", but normally we don't do that during "milestone window" week to avoid confusion).

Hope that helps,
Comment 5 Igor Fedorenko CLA 2012-01-30 21:59:47 EST 
I can confirm that http://build.eclipse.org/orbit/committers/orbit-I/20120130214911/I20120130214911/ has sjf4j-api with org/slf4j/LoggerFactory.class of expected size. I can also confirm that http://bugzilla.slf4j.org/show_bug.cgi?id=228 does not occur with the new slf4j-api orbit bundle.
Comment 6 Gunnar Wagenknecht CLA 2012-01-31 01:56:16 EST 
Thanks! It will be in Juno M6.