Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370130 - [Compatibility] View toolbar button doesn't show command name as tooltip
Summary: [Compatibility] View toolbar button doesn't show command name as tooltip
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 09:43 EST by Markus Keller CLA
Modified: 2012-03-13 08:26 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-01-30 09:43:31 EST 
4.2 M5, EGit 1.3.0.201201270251

Some view toolbar buttons don't show tooltips in 4.2 (but works fine in 3.8). 

An example is the "Refresh" button in the "Git Repositories" view. The button is contributed via

      <menuContribution
            locationURI="toolbar:org.eclipse.egit.ui.RepositoriesView">
         <command
               commandId="org.eclipse.egit.ui.RepositoriesViewRefresh"
               style="push">
         </command>

... where the command doesn't have a "tooltip" attribute. In 3.8, the name of the command is used in that case, see CommandContributionItem#updateToolItem().
Comment 1 Remy Suen CLA 2012-01-30 11:41:18 EST 
Fixed in master. Thanks for the bug report, Markus!
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=48126a25e5bd0ca343948731eee9a3cef00ad0f6
Comment 2 Remy Suen CLA 2012-03-13 08:26:48 EDT 
Verified with I20120312-1730 on Windows 7