370084 – [Search]SearchResultGenerator should use generic fileClient.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370084 - [Search]SearchResultGenerator should use generic fileClient.

Summary: [Search]SearchResultGenerator should use generic fileClient.

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	0.4
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	0.4 M2
Assignee:	libing wang
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-01-29 19:31 EST by libing wang
Modified:	2012-01-29 19:37 EST (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description libing wang

2012-01-29 19:31:21 EST

I found this issue while doing M2 sanity test.
SearchResultGenerator is always using this.registry.getService("orion.core.file") as the fileService, which is wrong if current file system is not Orion.
We should use fileClient so that it can pick up proper fileService implementation by the search location.

Comment 1 libing wang

2012-01-29 19:35:43 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3979345dc60cf06c71bb88fbeab7f835e235e104.

I've pushed the change to head.

Comment 2 libing wang

2012-01-29 19:37:16 EST

Hope it will go into M2.