Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370076 - [compiler] misplaced annotation before labeled callin binding is silently ignored
Summary: [compiler] misplaced annotation before labeled callin binding is silently ign...
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTJ (show other bugs)
Version: 2.1   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-29 12:52 EST by Stephan Herrmann CLA
Modified: 2012-09-22 16:12 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2012-01-29 12:52:32 EST
If a callin binding has both an annotation and a name:

   @SuppressWarnings("all") myCallin : foo <- bar;

the annotation is silently ignored, whereas this works:

   myCallin : @SuppressWarnings("all") foo <- bar;

The first example is tolerated by the parser as a byproduct of making the grammar LALR(1). It should be detected by specific checks in the parser implementation as we already do for other modifiers.
Comment 1 Stephan Herrmann CLA 2012-01-29 13:22:00 EST
Test and fix pushed via commit 3cef2f06214b2c4cd1af87f89c1fea4090a44939
Comment 2 Stephan Herrmann CLA 2012-09-22 16:12:07 EDT
Verified using build 2.2.0.201209221349