Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370063 - CSettingEntryFactory is not needed anymore
Summary: CSettingEntryFactory is not needed anymore
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 8.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.1.0   Edit
Assignee: Andrew Gvozdev CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-29 08:13 EST by Andrew Gvozdev CLA
Modified: 2012-02-29 13:23 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2012-01-29 08:13:49 EST 
CSettingEntryFactory is a factory class which was intended to cache ICSettingEntries in a project. With a obfuscating overcomplexity it was a source of obscure bugs. Having common cache of in ICSettingEntries CDataUtil this factory can be retired.
Comment 1 Andrew Gvozdev CLA 2012-01-29 09:27:27 EST 
Committed on master. That had a nice reducing ripple effect to some ugly classes. Test cases pass.
Comment 2 CDT Genie CLA 2012-02-29 13:23:31 EST 
*** cdt git genie on behalf of Andrew Gvozdev ***

    bug 370063: CSettingEntryFactory is not needed anymore

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d20555df6c97bd7c6f1fa58502933d8e08f4a2a6
Comment 3 CDT Genie CLA 2012-02-29 13:23:33 EST 
*** cdt git genie on behalf of Andrew Gvozdev ***

    bug 370063: CSettingEntryFactory is not needed anymore

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=625b28a9f7e5cae4373aa1cdbfc8bae2eb46fb41