Community
Participate
Working Groups
If you are in a top level folder, the Go Up command doesn't take you to "Orion Projects". I thought this was working, i remember testing it. Of course it shouldn't show up in the toolbar when at the very top.
Fix is available at remote branch origin/bug370032 The problem is that item.Parents is empty when you are a top level project, so we need special code to return a workspace root for that case. I had to add API to fileClient to support this, but I think it's a reasonable thing to add. I tested for the default file system. We know that the file system root property works for other systems (webdav) because this is the location used on the navigation outliner when multiple file systems are present. (See also bug 370897 for related issues with file system roots and parents) Libing, can you review?
Libing pointed out that the new fileClient API is not necessary since we map "#" to mean "root location of file system" in the navigator. So the fix is much simpler. Here is a new fix, the last commit in the branch origin/bug370032better Libing, can you review again?
The code looks good to me and behaves consistently with key board left key navigation on both Orion and web dav file systems. +1.
pushed. thanks again, Libing!