Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369989 - User feedback for plugin installation
Summary: User feedback for plugin installation
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.0 RC1   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 13:41 EST by John J. Barton CLA
Modified: 2013-01-30 15:41 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John J. Barton CLA 2012-01-27 13:41:11 EST
1. Click Installed Plugins on Orion toolbar
2. Enter http://www.google.com in the text box
3. Click install.

Feedback (way way down in the bottom corner!) says "installing..." then later it says 

Load timeout for plugin: http://www.google.com

It should say: 

 http://www.google.com is not an Orion Plugin

--------
Try the same thing with

http://localhost:8080/file/J/bundles/org.eclipse.orion.client.debug/web/debugPlugin.html

It stays "installing..." that is it no more feedback at all.
Comment 1 Simon Kaegi CLA 2012-10-04 16:28:20 EDT
Doing nothing more for 1.0 -- we now timeout after 5 seconds so at least the user knows there was a problem faster. The problem here is that we know very little about the success or failure of the content loaded in an iframe. e.g. we don't know if we got a 404 or if the page is indeed an html page but does not support the Orion plugin protocol.
Comment 2 Simon Kaegi CLA 2013-01-30 15:41:53 EST
We still have very limited information however we can now handle two distinct error cases (and we don't ever leave the user in a forever installing... status)

We now handle cases:
1) Where we get a 404 - by returning a failed to load message
2) Where the page loaded but did not do the plugin handshake - by returning a failed to perform plugin handshake message.