Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369977 - Operations icon not shown when there is no status message
Summary: Operations icon not shown when there is no status message
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 370782
  Show dependency tree
 
Reported: 2012-01-27 12:28 EST by Malgorzata Janczarska CLA
Modified: 2012-02-06 18:15 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2012-01-27 12:28:07 EST
Operations icon is shown only when there is a status message displayed next to it. If there is a task running but no status message is currently displayed we cannot open the minilist of operations to see its status. This may happen when operation what scheduled and page was reloaded before the operation was finished. If the icon was shown we could still check for its status and now we have to go to "Server operations" page.
Also when operation finishes it usually stays on the list for a while to allow user to see the result status. If we hide the icon user won't be able to open the minilist and view the status. It also looks a little weird when operation fails: the minilist popup is opened and user may see the error, but he icon is hidden. Because there is no icon the tooptip containing the list is shown on the top of the page (somewhere near Orion logo). And if the tooltip closes for any reason user is not able to see what was the error.
Comment 1 Susan McCourt CLA 2012-01-27 13:52:27 EST
ok, we'll try to find a better home for this, maybe some kind of animating icon that doesn't necessarily live next to the messages...I never realized til your explanation here what the case was where there was an icon and no progress, I find it happens quite a lot where you have that yellow icon and don't really know what it's telling you.

Just to clarify:  does that icon show when there's *any* operation (from any page) or is it just showing when the operation launched from the current page is running?  If it's the former, then we need it to be very subtle...
Comment 2 Susan McCourt CLA 2012-01-27 14:05:36 EST
I made a quickie fix for M2 that will put it on the right of the toolbar near the status area.  This may turn out to be a good home for it, maybe we just need to make sure the icon is cleaned up (I will make sure this happens, we are still working out which icons will have the yellow...)
Comment 3 Malgorzata Janczarska CLA 2012-01-27 17:25:07 EST
Thanks!

(In reply to comment #1)
> Just to clarify:  does that icon show when there's *any* operation (from any
> page)
This case.

> If it's the former, then we need it to be very subtle...
We have a way to tell if the operation is run on this page (since the last reload) or others, so there would be a possibility to make it more subtle if there are no operations from this page and lass subtle if there are any operations run recently by this page. But in general I agree that it should be subtle.
Comment 4 Susan McCourt CLA 2012-01-30 15:26:07 EST
I pushed a change for now that uses the existing eclipse animated "busy" icon when there a task icon running, and a subdued version of that icon when there is nothing running.  Note there is not yet a corresponding change to the error/warning versions of those icons (but I haven't noticed them popping up either).

I think it looks a lot better, and having the icon now in the toolbar on the right seems like a good spot.  (When it was on the right up in the banner it seemed much too prominent, but moving it by the progress message didn't really play well either). 

What do you think, Gosia?  If you are happy with the placement I think we can close this bug and then we are just needing to get icons.  We can track the icon itself in bug 364399.
Comment 5 Malgorzata Janczarska CLA 2012-01-31 12:53:41 EST
I like the placing of the icon now, only git status page is a problem. Always on loading the status page I get the icon hidden under the slider.
I like the idea of having an animation when there are some tasks running.(In reply to comment #4)

> Note there is not yet a corresponding change to the
> error/warning versions of those icons (but I haven't noticed them popping up
> either).
This looks a little odd now, but I understand that this is temporary and we'll change it when we have icons drown in bug 364399.
Comment 6 Susan McCourt CLA 2012-01-31 21:19:47 EST
i'll mark this fixed and we can address git status separately.  I noticed today running self hosted that it was better, the icon was always visible, although there's no padding.  We'll fix as part of making git status align more with other pages.

Can you think of an easy scenario where I can see the "task/error" or "task/warning" in action?  just curious.
Comment 7 Malgorzata Janczarska CLA 2012-02-01 07:49:30 EST
(In reply to comment #6)
> Can you think of an easy scenario where I can see the "task/error" or
> "task/warning" in action?  just curious.
Try to push to repository when there are no outgoing commits. Try also to merge where there are no incoming commits. To get an error try to clone repository that does not exist or you have no permissions to.
Comment 8 Susan McCourt CLA 2012-02-01 13:43:18 EST
(In reply to comment #7)
> (In reply to comment #6)
> > Can you think of an easy scenario where I can see the "task/error" or
> > "task/warning" in action?  just curious.
> Try to push to repository when there are no outgoing commits. Try also to merge
> where there are no incoming commits. To get an error try to clone repository
> that does not exist or you have no permissions to.

cool, thanks, that helps me make screenshots for icon designers.