Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369927 - [client] git log creates a tag but I don't see change in the UI
Summary: [client] git log creates a tag but I don't see change in the UI
Status: CLOSED INVALID
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 09:15 EST by Tomasz Zarna CLA
Modified: 2012-10-10 06:46 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-01-27 09:15:48 EST 
Steps:
1. Go to Git Log
2. Choose a commit and click the "Tag" action next to it
3. Enter a name and press Enter

This is what I get in the console:
TypeError: item is undefined
if (item.Location === this.root.Location) { explorer.js (line 160)

The tag seems to be created just fine, I can see it after reloading the page.
Comment 1 Susan McCourt CLA 2012-01-27 11:01:52 EST 
sounds like something I could have caused, I'll take it.
Comment 2 Susan McCourt CLA 2012-02-10 12:54:41 EST 
(In reply to comment #0)
> Steps:
> 1. Go to Git Log
> 2. Choose a commit and click the "Tag" action next to it
> 3. Enter a name and press Enter
> 
> This is what I get in the console:
> TypeError: item is undefined
> if (item.Location === this.root.Location) { explorer.js (line 160)
> 
> The tag seems to be created just fine, I can see it after reloading the page.

I don't see the TypeError anymore.  
But neither does the UI update.  Is it supposed to?
If I reload the page I can see the tag.
Comment 3 Tomasz Zarna CLA 2012-02-15 06:11:53 EST 
(In reply to comment #2)
> But neither does the UI update.  Is it supposed to?
> If I reload the page I can see the tag.

Szymon, Gosia?
Comment 4 Malgorzata Janczarska CLA 2012-10-10 06:46:09 EDT 
New got-log desn't display tags in the table, but in the popup. They are showed correctly.