Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369914 - "Node is null" error in git-log on switching between local and remote.
Summary: "Node is null" error in git-log on switching between local and remote.
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 06:31 EST by Malgorzata Janczarska CLA
Modified: 2012-01-27 11:14 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2012-01-27 06:31:13 EST 
1. Go to git log for local branch
2. Click "Switch to Remote" actions
3. The error in logs is shown:
TypeError: byId(node) is null
byId(node).innerHTML = "";
Comment 1 Malgorzata Janczarska CLA 2012-01-27 06:39:07 EST 
Probably a regression of some bug redesigning actions. We used to have "actions" td and "actionswrapper" span in it. Actions where rendered in "actionswrapper". Than we removed "actionswrapper" and actions where directly rendered in "actions" td. But there was a functions that was updating actions using "actionswrapper" id. I renamed "actions" to "actionswrapper", as "actionswrapper" is more commonly used in other places and now everything works again.
Comment 2 Susan McCourt CLA 2012-01-27 10:59:30 EST 
thanks, Gosia.  At some point I saw this bug go by and thought, "it's probably my fault" and then I forgot to follow up.
Comment 3 Malgorzata Janczarska CLA 2012-01-27 11:14:11 EST 
It didn't really break anything :)