Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369765 - RDTFileProxy needs improved error handling when a URL contains a bad connection id
Summary: RDTFileProxy needs improved error handling when a URL contains a bad connecti...
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: Project (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Linux Distros Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 20:18 EST by Corey Ashford CLA
Modified: 2012-05-15 12:29 EDT (History)
2 users (show)

See Also:

Attachments
Patch that improves error handling of URLs containing bad connection ids (2.38 KB, patch)
2012-01-25 20:18 EST, Corey Ashford CLA 		jjohnstn: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Corey Ashford CLA 2012-01-25 20:18:08 EST 
Created attachment 210094 [details]
Patch that improves error handling of URLs containing bad connection ids

If you try to manufacture an IRemoteFileProxy for a URL which uses either the remotetools or rse scheme, you will get an NPE in IRemoteFileProxy
Comment 1 Otavio Pontes CLA 2012-05-14 16:27:54 EDT 
This patch works for me. Can I apply it? Or is there something to fix?
Comment 2 Jeff Johnston CLA 2012-05-14 17:08:28 EDT 
(In reply to comment #1)
> This patch works for me. Can I apply it? Or is there something to fix?

Patch is fine.  For iplog approval, Corey needs to state here that he developed the patch 100% and had permission to do so from his employer and that the changes are EPL.  After that, the patch can be applied as it is <250 lines.
Comment 3 Corey Ashford CLA 2012-05-14 18:12:35 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> > This patch works for me. Can I apply it? Or is there something to fix?
> 
> Patch is fine.  For iplog approval, Corey needs to state here that he developed
> the patch 100% and had permission to do so from his employer and that the
> changes are EPL.  After that, the patch can be applied as it is <250 lines.

I developed this patch 100% and had permission from my employer, IBM Corp., to do so.
Comment 4 Corey Ashford CLA 2012-05-14 18:23:03 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > This patch works for me. Can I apply it? Or is there something to fix?
> > 
> > Patch is fine.  For iplog approval, Corey needs to state here that he developed
> > the patch 100% and had permission to do so from his employer and that the
> > changes are EPL.  After that, the patch can be applied as it is <250 lines.
> 
> I developed this patch 100% and had permission from my employer, IBM Corp., to
> do so.

Also, the changes I made are intended to be EPL.
Comment 5 Jeff Johnston CLA 2012-05-15 12:28:01 EDT 
Comment on attachment 210094 [details]
Patch that improves error handling of URLs containing bad connection ids

Patch under 250 lines.
Comment 6 Jeff Johnston CLA 2012-05-15 12:29:20 EDT 
Patch applied and modified slightly.  The PTP plugin should not be referenced on an exception created by this plug-in.  I have modified the exception to use the RDT proxy plug-in id.  I also modified the exception to use NLS for the error message.