Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369736 - [Search]Exception happens if the previous selection is stale.
Summary: [Search]Exception happens if the previous selection is stale.
Status: CLOSED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 15:10 EST by libing wang CLA
Modified: 2012-01-26 18:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2012-01-25 15:10:30 EST 
We are caching the currently selected match in the browser.
That says if you click on a match and go to the editor and come back later, you are not lost in the search page.
But if the file is stale, this does not works well. This can be easily reproduced by replace feature.
Comment 1 libing wang CLA 2012-01-26 18:20:35 EST 
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ad37c82259f020076c89dcb829d13174d7973876.

If the previous selection is stale we just default the selection to file 1 and at match 1. Also, the stale file is not involved in the iteration.