Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369734 - [Search]Disable commit commands when there is no files/matches are checked.
Summary: [Search]Disable commit commands when there is no files/matches are checked.
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 RC2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 14:59 EST by libing wang CLA
Modified: 2012-06-13 16:58 EDT (History)
1 user (show)

See Also:
mamacdon: review+

Attachments
patch file for hte fix (2.34 KB, text/plain)
2012-06-13 15:30 EDT, libing wang CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2012-01-25 14:59:25 EST 
In search replace preview, there is commit command to write all files with changes. This command should be disabled when there is nothing checked.
Comment 1 libing wang CLA 2012-06-13 15:30:09 EDT 
Created attachment 217315 [details]
patch file for hte fix
Comment 2 Mark Macdonald CLA 2012-06-13 16:52:28 EDT 
Reviewed the patch on branch 'branch_369734'
Comment 3 libing wang CLA 2012-06-13 16:58:31 EDT 
Thanks Mark for the review.

Pushed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5586b5c473a26989c1ee09a3a4f6ce089e72fb68.