Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369729 - editor marked dirty when no change or change reverted
Summary: editor marked dirty when no change or change reverted
Status: RESOLVED DUPLICATE of bug 205533
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 14:32 EST by Miles Parker CLA
Modified: 2012-01-25 19:26 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2012-01-25 14:32:26 EST
The editor is marked dirty whenever any user interaction occurs. For example if I click on any of the attribute popups the editor is marked dirty even when I haven't changed anything. The editor should only show as dirty on an actual resource delta.
Comment 1 Steffen Pingel CLA 2012-01-25 16:16:46 EST
I am not sure what you mean with any user interaction. On Gtk I can not reproduce the problem if I select the pre-selected value in a combo for instance. Leo, are you seeing this as well on Mac? Miles, do you have any tabs on the Task Editor besides Bugzilla and Context?
Comment 2 Miles Parker CLA 2012-01-25 17:31:00 EST
No, just those two. And naturally I just tried clicking on the attributes and it's not happening now. (!?) But I know the reverted change is reproducible:

1. Click on and change an Atrribute, e.g. "P2".
2. Change it back to "P1"

Editor is still marked dirty.

1. Focus on comment.
2. Enter text.
3. Delete text.

Editor is still marked dirty.

1. Focus on comment.
2. Enter text.
3. Undo.

Editor is still marked dirty.

BTW, Undo doesn't seem to work with the popups. Is this a known issue?
Comment 3 Leo Dos Santos CLA 2012-01-25 17:42:05 EST
Selecting the pre-selected combo value won't mark the editor dirty on Mac, no. But as Miles's most recent comment describes, making a change and then reverting the change leaves the editor dirty.
Comment 4 Steffen Pingel CLA 2012-01-25 18:03:10 EST
Thanks Leo. That's consistent with other editors, if you enter text and then delete it that's still considered a change. If you don't want a dirty editor you have to use undo. Proper undo support is indeed lacking in the task editor and tracked on bug 205533.

*** This bug has been marked as a duplicate of bug 205533 ***
Comment 5 Miles Parker CLA 2012-01-25 19:26:01 EST
(In reply to comment #4)
> Thanks Leo. That's consistent with other editors, if you enter text and then
> delete it that's still considered a change.

Gosh, you're right. It's even true for Apple software, which is my usability benchmark. How could I never have noticed that before? I guess it's more obvious with Eclipse because of the dirty marker.

Personally, I think everyone else is wrong. :D You should only need to save when there is a delta.