Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369711 - revisit repository page layout with respect to width
Summary: revisit repository page layout with respect to width
Status: RESOLVED INVALID
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 6.0 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 359621
Blocks:
  Show dependency tree
 
Reported: 2012-01-25 12:30 EST by Szymon Brandys CLA
Modified: 2015-04-01 10:27 EDT (History)
5 users (show)

See Also:


Attachments
screenshot of sites page (31.77 KB, image/png)
2012-01-25 17:23 EST, Susan McCourt CLA
no flags Details
Screenshot of 0.4M2 git-repository page (107.58 KB, image/png)
2012-02-01 13:49 EST, John J. Barton CLA
no flags Details
Example Screen Shot (24.28 KB, image/png)
2013-07-04 10:26 EDT, Anthony Hunter CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2012-01-25 12:30:23 EST
John J. Barton said:

"Having a huge blank space in the middle, separating the buttons for an item from the name of the item is not usable. One has to exert a lot of mental effort to imagine a line all the way across the page to line up the buttons with the repo.

The problem with previous soln was the repeated repeated layers of twisties and the missing link to navigation.

The previous soln did have white space, but it was all where it belonged, on the RHS and bottom. The main point about the white space is simple: there is space for more critical links like direct navigation."

Something to think about. I talked with Anton about that and he will look at the issue.
Comment 1 Susan McCourt CLA 2012-01-25 14:31:44 EST
Linda is still going to look at this as well, once we have basic toolbar and slideout visuals defined.  The work is tracked in bug 360986.
Comment 2 Susan McCourt CLA 2012-01-25 14:32:03 EST
also, Szymon's stripes on the page should help
Comment 3 Susan McCourt CLA 2012-01-25 17:23:59 EST
Created attachment 210085 [details]
screenshot of sites page

just happened to have a site page open, this is another approach
Comment 4 Susan McCourt CLA 2012-01-25 17:32:49 EST
Here is John's screensnap from original bug.
https://bugs.eclipse.org/bugs/attachment.cgi?id=210025

So in the sites case we make the content only as wide as needed.
In the nav case we use some min/max widths for some of the columns.
The answer here is probably to use some max width for the repo columns and let the buttons sit adjacent.  You could use a min width too if you want to prevent it being too dorky looking.

Then the question becomes...what about the section headers?  Do the align right on the browser or do we try to align them with the interior buttons.  This is the part Linda is playing with in the mockups.
Comment 5 Anton McConville CLA 2012-01-25 22:56:52 EST
Please push this fix ...

https://github.com/antonmc/orion.client/commit/3156bb30e9f514ee3d80c433af71479bc1f91871

Anton
Comment 6 Szymon Brandys CLA 2012-02-01 04:19:07 EST
The fix was pushed to .4M2. Should we consider the bug fixed?
Comment 7 John J. Barton CLA 2012-02-01 13:49:12 EST
Created attachment 210395 [details]
Screenshot of 0.4M2 git-repository page

The current UI requires 1000px. If the .setting min-width is removed and the repositoryActionsArea is placed after the title rather than a separate div, then the narrower UI will, I believe, work well enough. (In addition repositoryActionsArea should be a CSS class rather than an id, it appears once per repo).
Comment 8 Susan McCourt CLA 2012-02-09 17:01:13 EST
(In reply to comment #7)
> Created attachment 210395 [details]
> Screenshot of 0.4M2 git-repository page
> 
> The current UI requires 1000px. If the .setting min-width is removed and the
> repositoryActionsArea is placed after the title rather than a separate div,
> then the narrower UI will, I believe, work well enough. (In addition
> repositoryActionsArea should be a CSS class rather than an id, it appears once
> per repo).

This was basically the issue I had in bug 370280.  The page still doesn't need to clip as aggressively as it does but I was okay for 0.4 since we were under ipad width.

Reassigning to Szymon for future work and looking into your suggestions above.
Comment 9 Szymon Brandys CLA 2013-07-04 04:41:43 EDT
Anthony and Anton, I would like to continue this discussion and have agreement during 4.0M1. What are your suggestions here?
Comment 10 Anthony Hunter CLA 2013-07-04 10:26:30 EDT
Created attachment 233083 [details]
Example Screen Shot

I get no horizontal scrollbar until around 830px wide, rather than 1000px like before.

I do agree there is a huge space in the middle and on both the left and right that are not necessary and should be reduced before a scrollbar shows up.

I have attached a screen shot.
Comment 11 Szymon Brandys CLA 2015-04-01 10:27:20 EDT
This was about the old Git pages.