Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369708 - ModifyModulesComposite cannot block removal of modules
Summary: ModifyModulesComposite cannot block removal of modules
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2.5 P   Edit
Assignee: Elson Yuen CLA
QA Contact: Elson Yuen CLA
URL:
Whiteboard:
Keywords:
Depends on: 368503
Blocks:
  Show dependency tree
 
Reported: 2012-01-25 12:06 EST by Elson Yuen CLA
Modified: 2012-01-26 17:27 EST (History)
2 users (show)

See Also:

Attachments
v1.0 (2.83 KB, patch)
2012-01-25 12:16 EST, Elson Yuen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elson Yuen CLA 2012-01-25 12:06:33 EST 
+++ This bug was initially created as a clone of Bug #368503 +++

The ModifyModulesComposite class automatically checks if addition of a module to a server can proceed. If it cannot (if canModifyModules returns false) it puts up an error preventing the addition of the module to the right side of the wizard. 

It does not perform this check on removal of modules. If canModifyModules(null, selectedRemoval) would return an error status, the composite never checks it and so does not block the removal. 

The result is that a user thinks they can remove the module. Upon pressing 'finish', the removal cannot proceed, and an error message comes up. 

It would be much better if the composite checks this itself, as it does for additions.
Comment 1 Elson Yuen CLA 2012-01-25 12:16:06 EST 
Created attachment 210069 [details]
v1.0

Porting changes from bug 368503 to the 3.2.5 Patch stream.
Comment 2 Carl Anderson CLA 2012-01-26 17:27:33 EST 
Committed to R3_2_5_patches