Community
Participate
Working Groups
I'm attaching a screenshot showing the problem. When the plug-in title is very long or we just make the browser window smaller, the page does not behave well. The same problem on repo page where the problem is more visible.
Created attachment 210057 [details] The problem on plug-ins page
Created attachment 210058 [details] The problem on git repo page
*** Bug 369585 has been marked as a duplicate of this bug. ***
Please push this fix ... https://github.com/antonmc/orion.client/commit/3156bb30e9f514ee3d80c433af71479bc1f91871 Anton
Created attachment 210105 [details] Problem with longer titles and descriptions It looks better, but there is still problem for longer titles and descriptions. I think we should modify our title, description and action area classes too. I'm not sure what the good practice is, but I think that the content should be centered instead of left-aligned.
Ah - ok, I we now need to make some more width settings on the description area. I'm not so sure we should center everything, it wouldn't always solve the problem with large amounts of empty space between the blocks. I'd personally be happier tightening up the content - making some size decisions about it and cultivating some predictability in this layout. Some fields should wrap and grow vertically rather than grow without bounds horizontally. I can see that I'd need to tweak this some more - and I can also see that in the case of a really wide screen, we'd be left with some blank space at one side - however, the alternative would be to have distributed wide gaps between the blocks - in other words this page has empty space however we look at it - I favor the former approach. We also need to make good calls on the width so that it works well on a tablet and phone - though maybe we should tailor a UI for those.
(In reply to comment #6) > > We also need to make good calls on the width so that it works well on a tablet > and phone - though maybe we should tailor a UI for those. fyi...we have some tablet-ish media queries in ide.css so we could set standard width type css there.
I made some changes, but for some reason, was unable to push them to github from the status page. I've attached some files. So - if you look at the page - there are some lines with short descriptions on the left, and long lines of buttons on the right - and some with long descriptions on the left and short lines of buttons on the right. I'm not able to just make the description contents wrap. I think I'd need to work with the css, or maybe rethink some parts. So I needed to set some width restrictions on the descriptions as well as the page. And so this becomes a balancing act. I think I have a good balance - but that is testing only on my screen. You'll need to try on yours and may need to play with the numbers a bit. I would say that, although it works now, I'm uneasy with mixing these two kinds of rows on the same page. This also resonates with my personal taste of seeing the content ( and page ) simplified to use a left navigation to jump to the different sections. Sorry I wasn't able to push this ... not sure what the problem is. The change is small in gitRepositoryExplorer.js - search for tag-description in there. tag-description is a new css class - and so that is also in the settings.css file. I needed to make some minor changes to settings.js too - because it has slightly different width requirements on the same css.
Created attachment 210166 [details] js/css files
Created attachment 210206 [details] screenshot of commit page with latest code The latest changes to "stretch" are causing the commit details page to have tiny code boxes. I think we need to stop using stretch on that page.
Created attachment 210234 [details] designer mockup of repo page Here's a designer mockup of the repo page, which I quite like. To note: - for sections where everything underneath is the same model icon, use the model icon in the header. Helps declutter. - use the gray section heading bars and max out the width at a certain point, with the bars stopping where the content is. - we talked about centering but concluded that this doesn't look that great unless you have a "plated" fixed width page where even the banner stops. We aren't using this style, so the approach is to simply max out and then leave white space on right. - note the use of a single pixel border on the bottom of each item rather than shaded bars. With the "bar" look of the section header, using bars for content was getting busy. - fonts are smaller
(In reply to comment #10) > Created attachment 210206 [details] > screenshot of commit page with latest code > > The latest changes to "stretch" are causing the commit details page to have > tiny code boxes. I think we need to stop using stretch on that page. this has been fixed in bug 370175.
Heading on the repo pages are looking good. I think (?) we've fixed the scroll bar/layout issues for different pages? I think the only thing left here for the repo/commit page is to get the fonts smaller. Then we can close this? Anton, if you think this is not part of the shared css then let Szymon know.
I fixed font size on repo pages with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=107e7a0e423788ac34a82337414e9d0d5126f250. Fonts are not part of the shared css now and are unified with git-log page fonts.
