Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369663 - Invalid thread access during file search
Summary: Invalid thread access during file search
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-25 08:41 EST by Natalia Bartol CLA
Modified: 2020-05-14 11:38 EDT (History)
2 users (show)

See Also:

Attachments
PHPStructuredEditor.getAdapter non UI thread access fixed - patch (1.36 KB, patch)
2012-01-25 08:44 EST, Natalia Bartol CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Natalia Bartol CLA 2012-01-25 08:41:16 EST 
Build Identifier: 

ctrl + h causes Invalid thread access exception:

!ENTRY org.eclipse.core.jobs 4 2 2012-01-25 12:36:57.172
!MESSAGE An internal error occurred during: "File Search".
!STACK 0
org.eclipse.swt.SWTException: Invalid thread access
	at org.eclipse.swt.SWT.error(SWT.java:4282)
	at org.eclipse.swt.SWT.error(SWT.java:4197)
	at org.eclipse.swt.SWT.error(SWT.java:4168)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:466)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:404)
	at org.eclipse.swt.widgets.Control.isVisible(Control.java:3359)
	at org.eclipse.php.internal.ui.editor.PHPStructuredEditor.getAdapter(PHPStructuredEditor.java:2402)
	at org.eclipse.search2.internal.ui.text.EditorAnnotationManager.createHighlighter(EditorAnnotationManager.java:182)
	at org.eclipse.search2.internal.ui.text.EditorAnnotationManager.addAnnotations(EditorAnnotationManager.java:241)
	at org.eclipse.search2.internal.ui.text.EditorAnnotationManager.searchResultChanged(EditorAnnotationManager.java:128)
	at org.eclipse.search.ui.text.AbstractTextSearchResult.fireChange(AbstractTextSearchResult.java:265)
	at org.eclipse.search.ui.text.AbstractTextSearchResult.addMatches(AbstractTextSearchResult.java:105)
	at org.eclipse.search.internal.ui.text.FileSearchQuery$TextSearchResultCollector.flushMatches(FileSearchQuery.java:146)
	at org.eclipse.search.internal.ui.text.FileSearchQuery$TextSearchResultCollector.acceptFile(FileSearchQuery.java:59)
	at org.eclipse.search.internal.core.text.TextSearchVisitor.processFile(TextSearchVisitor.java:247)
	at org.eclipse.search.internal.core.text.TextSearchVisitor.processFiles(TextSearchVisitor.java:196)
	at org.eclipse.search.internal.core.text.TextSearchVisitor.search(TextSearchVisitor.java:172)
	at org.eclipse.search.internal.core.text.TextSearchVisitor.search(TextSearchVisitor.java:184)
	at org.eclipse.search.core.text.TextSearchEngine$1.search(TextSearchEngine.java:54)
	at org.eclipse.search.internal.ui.text.FileSearchQuery.run(FileSearchQuery.java:182)
	at org.eclipse.search2.internal.ui.InternalSearchUI$InternalSearchJob.run(InternalSearchUI.java:91)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Reproducible: Always
Comment 1 Natalia Bartol CLA 2012-01-25 08:44:56 EST 
Created attachment 210050 [details]
PHPStructuredEditor.getAdapter non UI thread access fixed - patch

This behaviour is a side effect of Bug 368951 (see comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=368951#c2).

Attached patch wraps fPHPOutlinePage.getControl().isVisible() in Dispaly.syncExec().
Comment 2 Roy Ganor CLA 2012-01-26 06:44:21 EST 
thanks!
Comment 3 Sylvia Tancheva CLA 2012-02-10 10:52:48 EST 
I do not see any errors now. Closing