Community
Participate
Working Groups
I am reviewing code contributions today. I reviewed the first commit, it looked reasonable, so I cherry picked it. Then I tested it to make sure it did what I thought, and I was unsure. Wrote a note in the bug to the contributor. Found the next commit, cherry picked it, tested it, I like it. How can I push just this commit from my master branch?
this is really a philosophical question about the contribution workflow, so I'll update bug 369591. I think the answer to this particular question is that I should be making a branch for each contribution. But the whole workflow is just so cumbersome that I was trying to cheat and cherry pick all the commits to master.
I updated the wiki page for processing contributions to remind the committer to make a branch first. (yes we should know that but a reminder never hurts).