Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369590 - Highlight service sometimes breaks editor
Summary: Highlight service sometimes breaks editor
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 15:11 EST by Mark Macdonald CLA
Modified: 2012-01-26 09:59 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-01-24 15:11:20 EST 
Orion I20120122-2230

The infrastructure that lets a plugin (eg. orion-codemirror [1]) contribute highlighting information via a service does not correctly handle service metadata updates (which cause the service to be removed from the registry). For example:

1. Install the orion-codemirror plugin
2. Wait for the cached copy of the plugin's metadata to expire
3. Load the editor page on a file.
4. At this point the editor will break and you'll get "Service was unregistered" errors until you reload the plugin.



[1] http://mamacdon.github.com/orion-codemirror/codeMirrorPlugin.html
Comment 1 Mark Macdonald CLA 2012-01-24 18:39:06 EST 
A service add/remove is now handled correctly.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dfaa5bec36046d1e370733b03b767508db9dfc7f
Comment 2 Mark Macdonald CLA 2012-01-26 09:59:19 EST 
.