Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369587 - V2 Validation Framework ignoring IResourceDelta.REMOVED events
Summary: V2 Validation Framework ignoring IResourceDelta.REMOVED events
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.2.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5 P   Edit
Assignee: Rosendo Martinez CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 15:05 EST by Rosendo Martinez CLA
Modified: 2012-03-22 16:06 EDT (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
Proposed R3_2_5_P patch (5.35 KB, patch)
2012-01-24 15:09 EST, Rosendo Martinez CLA 		no flags Details | Diff
Proposed R3.2.5_P patch (5.17 KB, patch)
2012-03-07 12:52 EST, Rosendo Martinez CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rosendo Martinez CLA 2012-01-24 15:05:51 EST 
Build Identifier: 

In the old validation framework we got notified for remove events and still
need this support in the new V2 framework.  Currently validators using the new
framework are only getting notified for add and change events.  It looks like
remove events are filtered out in ValBuilderJob.visit(IResourceDelta delta).

To fix this, the project that contains the removed resource will be validated once.

Reproducible: Always
Comment 1 Rosendo Martinez CLA 2012-01-24 15:09:34 EST 
Created attachment 210005 [details]
Proposed R3_2_5_P patch
Comment 2 Chuck Bridgham CLA 2012-01-24 15:13:06 EST 
looks good - waiting on PMC approval from https://bugs.eclipse.org/bugs/show_bug.cgi?id=257640
Comment 3 Rosendo Martinez CLA 2012-01-25 16:53:57 EST 
Closing as Invalid. Fix is dropped only into HEAD for now.
Comment 4 Carl Anderson CLA 2012-02-22 13:09:40 EST 
Comment on attachment 210005 [details]
Proposed R3_2_5_P patch

Since this bug was invalid, this attachment should be obsolete.
Comment 5 Rosendo Martinez CLA 2012-03-07 12:05:55 EST 
Reopening this bug to include the fix in R3.2.5 P
Comment 6 Rosendo Martinez CLA 2012-03-07 12:52:24 EST 
Created attachment 212235 [details]
Proposed R3.2.5_P patch

This patch contains the fix for a defect found in the Dependent Resource. I was sending a REMOVE flag for the Dependent Resource but NO_CHANGE flag should be sent.
Comment 7 Rosendo Martinez CLA 2012-03-22 16:06:31 EDT 
Code committed and released to R3_2_5_patches.