Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369510 - Unable to set the encoding without specifying the source attachment
Summary: Unable to set the encoding without specifying the source attachment
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 08:01 EST by Satyam Kandula CLA
Modified: 2012-01-25 10:43 EST (History)
3 users (show)

See Also:
markus.kell.r: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Satyam Kandula CLA 2012-01-24 08:01:39 EST 
One can export a jar with source code. If this jar is added as a depndent external jar , it's source can be viewed without having an entry in the source attachment. I am unable to set the encoding for this kind of jars. 
If I change the encoding for this kind of jar and click OK, the dialog box gets dismissed, but If I open the dialog box again, I don't see the changes. 
UI should allow to set the encodings without the need to specify the source attachment.
Comment 1 Deepak Azad CLA 2012-01-24 08:04:41 EST 
I had disabled specification of encoding without the specification of source attachment on purpose, thinking that this was wrong. I will fix this.
Comment 2 Deepak Azad CLA 2012-01-25 03:45:15 EST 
Fixed in master - 2217aa07482ecaedbaad3aeb0b322b3350a73327
Comment 3 Markus Keller CLA 2012-01-25 07:25:59 EST 
Setting the encoding works, but when I open the dialog again, then "Workspace location" is checked and the combo contains the wrong source encoding.
Comment 4 Deepak Azad CLA 2012-01-25 09:14:44 EST 
(In reply to comment #3)
> Setting the encoding works, but when I open the dialog again, then "Workspace
> location" is checked and the combo contains the wrong source encoding.
Doh!

Fixed in master - 21dd9abc8cf12913e7e25045558033bf6e34bd1f
Comment 5 Markus Keller CLA 2012-01-25 10:43:08 EST 
Looks good now.