Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369457 - Creation of new SpecObjects in an empty Specification is not intuitive
Summary: Creation of new SpecObjects in an empty Specification is not intuitive
Status: RESOLVED FIXED
Alias: None
Product: MDT.RMF
Classification: Modeling
Component: ProR (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: 0.6.0   Edit
Assignee: Michael Jastram CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 374186 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-23 17:03 EST by Michael Jastram CLA
Modified: 2014-03-14 09:12 EDT (History)
3 users (show)

See Also:


Attachments
Proposed Patch - Part 1 of 3 (21.38 KB, patch)
2012-12-30 07:00 EST, Christoph Pieper CLA
eclipse: iplog+
Details | Diff
Proposed Patch - Part 2 of 3 (5.25 KB, patch)
2012-12-30 07:01 EST, Christoph Pieper CLA
eclipse: iplog-
Details | Diff
Proposed Patch - Part 3 of 3 (25.51 KB, patch)
2012-12-30 07:02 EST, Christoph Pieper CLA
eclipse: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Jastram CLA 2012-01-23 17:03:30 EST
If a Specification does not have any Entries, it is not possible to create a first entry through the context menu.

A workaround is to use the outline, but this is not very intuitive.
Comment 1 Michael Jastram CLA 2012-03-16 10:05:41 EDT
*** Bug 374186 has been marked as a duplicate of this bug. ***
Comment 2 Michael Jastram CLA 2012-05-31 08:31:50 EDT
The proposed solution is to allow right-clicking in the empty Editor.  This already pops up a context menu, but with respect to the current selection.  Instead, the parent Specification must be the selection that the context menu refers to.
Comment 3 Christoph Pieper CLA 2012-12-28 17:59:48 EST
There is a similar Problem with the Column Configuration Dialog:

If you create a new Specification Type there are no colums defined. In this case it is impossible to add new columns in the Column Configuration Dialog, since there are no Siblings to add to.
Comment 4 Christoph Pieper CLA 2012-12-30 07:00:35 EST
Created attachment 225094 [details]
Proposed Patch - Part 1 of 3

Patch for Agile Grid - CellSelectionManager.java
Comment 5 Christoph Pieper CLA 2012-12-30 07:01:18 EST
Created attachment 225095 [details]
Proposed Patch - Part 2 of 3

Patch for ProrAgileGrid.java
Comment 6 Christoph Pieper CLA 2012-12-30 07:02:05 EST
Created attachment 225096 [details]
Proposed Patch - Part 3 of 3

Patch for ProrAgileGridViewer.java
Comment 7 Michael Jastram CLA 2013-01-07 07:08:21 EST
Duplicate of Bug 397550, but not closed due to attached patches.
Comment 8 Michael Jastram CLA 2013-01-08 06:19:33 EST
Thank you for the contributions!

- Patch 1 is great the way it is, I'll incorporate it on Sourcefoge into AgileGrid.

- Patch 2 is not necessary, if parts of Patch 3 are applied: by setting the selection via ProrAgileGridViewer.registerSelectionChangedListener(), the menu will be based on the correct element.

- Patch 3 points in the right direction, but does not work as shown here.  Specifically, it does two things: Managing the selection and preventing flickering.

The code for selection management has been simplified and implemented -thanks a lot.  The code for preventing flickering prevents Drag and Drop to work properly (at least on my system), therefore I omitted it for the time being.  To capture this, I opened Bug 397661.
Comment 9 Michael Jastram CLA 2013-01-08 08:31:39 EST
New SpecObjects can now be created by right-clicking in the empty Editor area.
Comment 10 Christoph Pieper CLA 2013-01-10 13:20:03 EST
Comment on attachment 225096 [details]
Proposed Patch - Part 3 of 3

Any code added to the three files posted here was solely written by myself and I have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 11 Mark Broerkens CLA 2014-01-24 07:28:45 EST
Comment on attachment 225096 [details]
Proposed Patch - Part 3 of 3

Set iplog+ in order to include this patch into the automatically generated ip log.
Comment 12 Mark Broerkens CLA 2014-01-24 08:04:13 EST
Comment on attachment 225094 [details]
Proposed Patch - Part 1 of 3

added iplog+ since the agilegrid (EPL) code is redistributed via RMF
Comment 13 Mark Broerkens CLA 2014-01-24 08:06:02 EST
Comment on attachment 225095 [details]
Proposed Patch - Part 2 of 3

set iplog- since the patch was not required. See comment #8.
Comment 15 Mark Broerkens CLA 2014-03-14 09:12:03 EDT
Proposed patch 3 (ProrAgileGridViewer) was committed on 07.01.2013:
http://git.eclipse.org/c/rmf/org.eclipse.rmf.git/commit/?h=develop&id=44d31dbd7465ca5383116e2f307dba0f9d07f3e4

9 lines of code added: no CQ required.