Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369433 - [sites] - can't open the edit site page from a self hosted site
Summary: [sites] - can't open the edit site page from a self hosted site
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 13:41 EST by Susan McCourt CLA
Modified: 2012-04-19 11:47 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-01-23 13:41:10 EST 
It is not possible to open/edit a site from a self hosted site.
This makes it hard to test that page when making changes to it.
Mark says this is a side effect of bug 360274.

The error is
 Error: Unable to load http://localhost:8080/site/T status:0
Comment 1 Mark Macdonald CLA 2012-04-19 10:17:45 EDT 
The fix from Bug 360274 disabled the "un-qualification" (ie. stripping off the current server's hostname and port) done on URLs returned through the sites API. This was to prevent the server from mangling your mapping rules when you were editing a self-hosting site config. But a side effect was that when you visited the Sites page on an inner site, the Location URLs pointed to localhost, not yoursite.orion.eclipse.org, so most of the features didn't work.

I modified that fix so that the sites API un-qualifies only the "Location" URLs that it returns, but not others. This means you can click through to the site editor and use it (so we can test the UI again, yay) but your self-hosting setup is still safe.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=282e20bcf4456b99acba4538c4c121c59d2d0c77
key
Comment 2 Susan McCourt CLA 2012-04-19 11:47:59 EDT 
(In reply to comment #1)
(so we can test the UI again, yay) 

Thanks, Mark!  Hopefully I won't break you so routinely anymore when I do big command refactorings.