Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369377 - Output for command -data-read-memory should include value of 'nr-bytes' field
Summary: Output for command -data-read-memory should include value of 'nr-bytes' field
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.1.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0.2   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 06:42 EST by Harish Dewan CLA
Modified: 2014-01-29 23:00 EST (History)
4 users (show)

See Also:


Attachments
search for 'nr-bytes' (884 bytes, patch)
2012-01-23 06:45 EST, Harish Dewan CLA
no flags Details | Diff
update the patch with copyright (1.32 KB, patch)
2012-01-24 01:11 EST, Harish Dewan CLA
cdtdoug: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harish Dewan CLA 2012-01-23 06:42:15 EST
Build Identifier: I20110613-1736

In MIDataReadMemoryInfo minor correction is there.
In function 'parseResult', while parsing the output results the code is trying to parse 'nr-bytes="x"', it is actually searching for "total-bytes"



Thanks
Harish Dewan
Tensilica India

Reproducible: Always
Comment 1 Harish Dewan CLA 2012-01-23 06:45:24 EST
Created attachment 209905 [details]
search for 'nr-bytes'

search for 'nr-bytes'
Comment 2 Marc Khouzam CLA 2012-01-23 11:12:38 EST
I guess this was never noticed because we don't seem to be using this info.

Thanks for noticing it.
Comment 3 Marc Khouzam CLA 2012-01-23 11:13:34 EST
What company do you work for so I can put the proper copyright?
Comment 4 Harish Dewan CLA 2012-01-24 01:09:44 EST
(In reply to comment #3)
> What company do you work for so I can put the proper copyright?

I Work for Tensilica Technologies, I will update the patch with copyrights. Thanks.
Comment 5 Harish Dewan CLA 2012-01-24 01:11:25 EST
Created attachment 209953 [details]
update the patch with copyright

update the patch with copyright
Comment 6 Marc Khouzam CLA 2012-01-24 10:30:03 EST
Thanks for the patch.  I committed it to master and cdt_8_0.

Shouldn't we have a method to access this value though?
It is currently package-private...
Comment 7 CDT Genie CLA 2012-02-29 13:21:59 EST
*** cdt git genie on behalf of Harish Dewan ***

    Bug 369377: Output for command -data-read-memory should include value of 'nr-bytes' field

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=7dcb19c4c143fc9bdf6154e411d3c452c5c62afd
Comment 8 CDT Genie CLA 2012-02-29 13:22:01 EST
*** cdt git genie on behalf of Harish Dewan ***

    Bug 369377: Output for command -data-read-memory should include value of 'nr-bytes' field

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d5dbaef1593e865917fc37a10ee52d505cf18791