Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369364 - [DB4O] Performance reports should be logged via a Tracer, not via OM.LOG
Summary: [DB4O] Performance reports should be logged via a Tracer, not via OM.LOG
Status: CLOSED WONTFIX
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Victor Roldan Betancort CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 04:53 EST by Stefan Winkler CLA
Modified: 2019-11-08 02:41 EST (History)
1 user (show)

See Also:
vroldanbet: review+
stepper: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Winkler CLA 2012-01-23 04:53:46 EST 
DB4OStoreAccessor contains several performance measurement reports such as

OM.LOG.debug("Commit took -> " + (end - start) + " milliseconds");

This leads to a lot of unwanted log output in production settings. Therefore these statements should be replaced by tracing, which can be enabled and disabled as needed.
Comment 1 Stefan Winkler CLA 2012-01-23 05:15:16 EST 
Committed to branch bugs/369364 and pushed to origin

commit f85b87a594f305e9af59c514163c38432731a667
Author: Stefan Winkler <stefan@winklerweb.net> 2012-01-23 11:09:51
Committer: Stefan Winkler <stefan@winklerweb.net> 2012-01-23 11:09:51
Parent: ed56b1db68e515861afb0afce574106f7191bb04 (On Hudson run only the DB/H2 tests)
Branches: origin/bugs/369364, bugs/369364

[369364] [DB4O] Performance reports should be logged via a Tracer, not
via OM.LOG 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=369364
Comment 2 Stefan Winkler CLA 2012-01-23 05:20:40 EST 
Vik, can you please have a look. Maybe measuring the time of storing one single revision does not really need to be measured, as it is always 0 or 1 millisecond on my machine. So maybe the measuring code should be eliminated from writeRevision completely ….
Comment 3 Victor Roldan Betancort CLA 2012-01-23 17:29:11 EST 
Stefan, 

the patch looks good. Those traces are now probably not useful, I assume they were in the past. You can safely remove them. If necessary, they can be added while doing performance tunning of profiling.
Comment 4 Victor Roldan Betancort CLA 2012-02-29 08:56:35 EST 
Hi Stefan,

is it possible to mark as fixed this bug already?
Comment 5 Victor Roldan Betancort CLA 2012-02-29 08:59:04 EST 
Ah, this isn't committed to master yet. I could merge that, if you want.
Comment 6 Eike Stepper CLA 2012-03-21 09:05:02 EDT 
Guys, what's the status of this bug?
Comment 7 Victor Roldan Betancort CLA 2012-03-21 09:06:27 EDT 
AFAIK, there is a branch created, but the code is not merged. I think Stefan suggested to add some additional changes before merging.
Comment 8 Stefan Winkler CLA 2012-04-01 14:10:40 EDT 
Sorry for the late reaction.

Vik, please decide if you still need the log entry in 
protected void writeRevision(InternalCDORevision revision, OMMonitor monitor)
(DB4OStoreAccessor lines 692 and 700) because it seems too fine-granular to me (outputs 0 or 1 millisecond for me all the time)

If you still need it, please merge the branch and resolve the bug.

If you don't need it, please remove the logging at the indicated position and then merge and resolve.

Thanks ;-)
Comment 9 Eike Stepper CLA 2012-04-04 19:16:49 EDT 
Go ahead...
Comment 10 Eike Stepper CLA 2012-08-14 22:51:26 EDT 
Moving all open issues to 4.2. Open bugs can be ported to 4.1 maintenance after they've been fixed in master.
Comment 11 Eike Stepper CLA 2013-06-27 04:06:26 EDT 
Moving all outstanding enhancements to 4.3
Comment 12 Eike Stepper CLA 2014-08-19 09:23:56 EDT 
Moving all open enhancement requests to 4.4
Comment 13 Eike Stepper CLA 2014-08-19 09:35:23 EDT 
Moving all open enhancement requests to 4.4
Comment 14 Eike Stepper CLA 2015-07-14 02:09:46 EDT 
Moving all open bugzillas to 4.5.
Comment 15 Eike Stepper CLA 2016-07-31 00:52:29 EDT 
Moving all unaddressed bugzillas to 4.6.
Comment 16 Eike Stepper CLA 2017-12-28 01:16:19 EST 
Moving all open bugs to 4.7
Comment 17 Eike Stepper CLA 2019-11-08 02:15:34 EST 
Moving all unresolved issues to version 4.8-
Comment 18 Eike Stepper CLA 2019-11-08 02:41:15 EST 
DB4O support has been deprecated, see bug 552307.