Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369344 - settings local storage should use user preferences
Summary: settings local storage should use user preferences
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5   Edit
Assignee: Anton McConville CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-22 16:25 EST by Susan McCourt CLA
Modified: 2012-03-27 13:51 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-01-22 16:25:13 EST 
The settings.js file is doing some preference storing in localstorage.  This should be reconciled with the preferences service (which uses localStorage as a cache but also saves for user on server).  I think the main missing piece is that Anton is using some notifications from localStorage to make sure that the editor updates on the fly.  So we would need some kind of listener mechanism in the preferences service, probably based on what Anton did.
Comment 1 Anton McConville CLA 2012-03-27 13:50:00 EDT 
Resolved this. Using preferences local storage for now. There seem to be limitations with the user preferences. Will cut to that soon. Added some helper functions to preferences for settings. Will need to be reviewed/improved.
Comment 2 Anton McConville CLA 2012-03-27 13:51:27 EDT 
Submitted a fix for this.