Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369306 - PluginConverter.convertManifest javadoc ask for a directory when archives are supported
Summary: PluginConverter.convertManifest javadoc ask for a directory when archives are...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: Juno M5   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 18:30 EST by Curtis Windatt CLA
Modified: 2012-01-23 09:21 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2012-01-20 18:30:23 EST 
org.eclipse.orgi.service.PluginConverter

Both convertManifest() methods ask for a directory:
"Converts a plug-in/fragment manifest at the given source base location (a directory)..."

I think this is what led PDE to not support non-osgi plugins in target platforms around 3.4 (bug 368753).

Investigating and testing the code, it appears to read archive files (jars/wars) correctly.

Please update the javadoc so we don't make the same mistake again :)
Comment 1 Thomas Watson CLA 2012-01-23 09:09:13 EST 
I will fix the javadoc.