Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369259 - error when deleting dynamic web project
Summary: error when deleting dynamic web project
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3.2   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_Approved
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 11:56 EST by Dimo Stoilov CLA
Modified: 2012-02-01 06:08 EST (History)
1 user (show)

See Also:
dimitar.giormov: pmc_approved? (david_williams)
dimitar.giormov: pmc_approved? (raghunathan.srinivasan)
dimitar.giormov: pmc_approved? (naci.dai)
dimitar.giormov: pmc_approved? (deboer)
dimitar.giormov: pmc_approved? (neil.hauge)
dimitar.giormov: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
cbridgha: review+


Attachments
the trace (1.47 KB, text/plain)
2012-01-20 11:56 EST, Dimo Stoilov CLA
no flags Details
simple check is added is exception is thrown due to closed deleted project. (2.46 KB, patch)
2012-01-23 08:52 EST, Dimitar Giormov CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimo Stoilov CLA 2012-01-20 11:56:42 EST
Created attachment 209839 [details]
the trace

used build: http://download.eclipse.org/webtools/downloads/drops/R3.4.0/S-3.4.0M4-20111212171647/ 

1) create dynamic web project 3.0
2) create a servlet
3) delete the project - after the project gets deleted an error popup appears saying: An internal error occurred during: "Loading descriptor for ww33.".
The project <P/ww33> is not accessible.

attached is the trace
Comment 1 Dimitar Giormov CLA 2012-01-23 08:45:25 EST
I can reproduce it 3.3.1 as well
Comment 2 Dimitar Giormov CLA 2012-01-23 08:52:55 EST
Created attachment 209912 [details]
simple check is added is exception is thrown due to closed deleted project.
Comment 3 Dimitar Giormov CLA 2012-01-23 08:53:24 EST
@Chuck: can you review the change.
Comment 4 Chuck Bridgham CLA 2012-01-23 09:37:16 EST
yep looks good - make sure this gets into HEAD as well
Comment 5 Dimitar Giormov CLA 2012-01-25 05:00:31 EST
Once the builds are declared I will commit it in HEAD and 3_3_maintenance
Comment 6 Dimitar Giormov CLA 2012-01-30 08:49:31 EST
Q: Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

A: This bug occurs often when deleting a simple Dynamic web project.
An error dialog pops up with the trace attached, while delete operation is executed.

Q: Is there a work-around? If so, why do you believe the work-around is insufficient? 

A: There is a workaround - if on the web project the deployment descriptor is expanded to the level where the resources are loaded the exception will not occur.

Q: How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

A: The fix has been tested manually.


Q: Give a brief technical overview. Who has reviewed this fix? 

A: The fix is simple. If the exception occurs in the implementation of the job a check is done if this is due to inaccessible project. If so the job is canceled.

Q: What is the risk associated with this fix? 
A: Low risk
Comment 7 Dimitar Giormov CLA 2012-02-01 06:08:35 EST
committed and released in 3_3_maintenance and HEAD