Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369225 - Cleanup pre GTK 2.4 leftovers.
Summary: Cleanup pre GTK 2.4 leftovers.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M5   Edit
Assignee: Alexander Kurtakov CLA
QA Contact: Silenio Quarti CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 340067
  Show dependency tree
 
Reported: 2012-01-20 08:42 EST by Alexander Kurtakov CLA
Modified: 2012-01-24 13:00 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2012-01-20 08:42:05 EST 
This is a lot of code that can not be used nowadays but just makes it
harder to kill deprecated functions in order to use newer GTK versions.

Commit:
http://fedorapeople.org/gitweb?p=akurtakov/public_git/eclipse.platform.swt.git;a=commit;h=db7d33313b6ee92cdb9e904f457bbed53c631f13
Comment 1 Silenio Quarti CLA 2012-01-20 14:10:15 EST 
Released:
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=704f9377fdfbc3f0c12e11665b0fc2e8c6f9b051

Note that the old code path for getForegroundColor() was left (it should be removed). Also, the sub implementation of gtk_expose_event() is not needed.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit?id=70fed7586064df83841bf23cc3bbbf080c822668
Comment 2 Alexander Kurtakov CLA 2012-01-20 14:22:57 EST 
Sorry, I'm still not that familiar with the codebase to notice such details.
I looked at the OBSCURED thing but decided to leave it there because I was not sure.