Comment 1 Thomas Watson 2012-01-20 10:19:03 EST

Can you explain why you need this.  We don't compile the classes of this project, I suspect you are.  I assume you would need something similar in org.eclipse.osgi.services project.

Comment 2 Krzysztof Daniel 2012-01-23 08:07:34 EST

I compile those classes each time I build Eclipse with eclipse-build.

The source-packaging script first deletes binaries, and then extracts sources.

The source is java 1.5, but the manifest statement is:
Bundle-RequiredExecutionEnvironment: OSGi/Minimum-1.2,
 CDC-1.1/Foundation-1.1,
 J2SE-1.4

PDE Build uses the 1.4 syntax derived from required execution environment and the build fails. 

Yes, you are right that I need that change in org.eclipse.osgi.services, too.

Comment 3 Krzysztof Daniel 2012-02-08 04:52:26 EST

Thomas, are there any chances that this will get into M6?

Comment 4 Thomas Watson 2012-02-08 09:56:17 EST

(In reply to comment #3)
> Thomas, are there any chances that this will get into M6?

yes, thanks for the reminder ;-)

Comment 5 Thomas Watson 2012-02-16 17:06:36 EST

Taking a closer look at the patch I am confused since it appears to be against org.eclipse.equinox.util but the title indicates org.eclipse.osgi.util.  Which bundle is this for?  Perhaps you can include a new patch that also includes org.eclipse.osgi.services if you need the change there also?

Comment 6 Krzysztof Daniel 2012-03-05 10:05:04 EST

Created attachment 212069 [details]
Patch for proper bundles

Do you think I could contribute build.xml's for those two projects? Having a way to build them in an automated way from source does not look like a bad idea.

The previous patch that I have attached is also valid, but for another project, and I guess the explanation for it will be different.

Comment 7 Krzysztof Daniel 2012-03-05 10:26:28 EST

restore milestone & assignee

Comment 8 Thomas Watson 2012-03-08 08:29:55 EST

I released a modified patch (incremented copyright dates) with commit:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=47f021c0ec945529add384c6b2d153caf027792d

(In reply to comment #6)
> Do you think I could contribute build.xml's for those two projects? Having a
> way to build them in an automated way from source does not look like a bad
> idea.

In Equinox we just want to take what OSGi gives us for the .class files.  But if you want to contribute some build.xml files that can be used by others that is fine, but I don't want to use them in our own builds done at eclipse.

Please open a separate bug for that.  Thanks.

Comment 9 Thomas Watson 2012-03-08 08:30:15 EST

Forgot to mark as fixed.