Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369214 - HotSwapHandler should use AggregateLifeCycle.addBean()
Summary: HotSwapHandler should use AggregateLifeCycle.addBean()
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 7.5.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 07:38 EST by Thomas Becker CLA
Modified: 2013-03-14 23:49 EDT (History)
1 user (show)

See Also:

Attachments
1st commit code format (5.68 KB, patch)
2012-01-23 04:11 EST, Thomas Becker CLA 		no flags Details | Diff
2nd commit actual patch (2.89 KB, patch)
2012-01-23 04:11 EST, Thomas Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Becker CLA 2012-01-20 07:38:55 EST 
Build Identifier: 

See summary.

Reproducible: Always
Comment 1 Greg Wilkins CLA 2012-01-22 20:52:07 EST 
should be able to be done with handler wrapper changes

*** This bug has been marked as a duplicate of bug 369072 ***
Comment 2 Thomas Becker CLA 2012-01-23 04:11:21 EST 
Created attachment 209894 [details]
1st commit code format

HotSwapHandler does not extend HandlerWrapper. So this is either two different patches or I can see if both can be combined in some way. Or am I getting you wrong here?

However here's a patch for HotSwapHandler.
Comment 3 Thomas Becker CLA 2012-01-23 04:11:46 EST 
Created attachment 209895 [details]
2nd commit actual patch
Comment 4 Thomas Becker CLA 2012-01-23 04:14:34 EST 
Not sure if this is really a duplicate. See comment above.
Comment 5 Thomas Becker CLA 2012-03-01 09:33:13 EST 
Pushed to gerrit:

https://git.eclipse.org/r/#/c/5207/
https://git.eclipse.org/r/#/c/5208/
Comment 6 Greg Wilkins CLA 2013-03-14 23:49:11 EDT 
applied