Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369112 - DoSFilterTest intermittently fails on MacOs
Summary: DoSFilterTest intermittently fails on MacOs
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 minor (vote)
Target Milestone: 7.5.x   Edit
Assignee: Thomas Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 12:05 EST by Thomas Becker CLA
Modified: 2012-02-22 09:03 EST (History)
3 users (show)

See Also:

Attachments
proposed patch (2.18 KB, patch)
2012-01-30 06:40 EST, Thomas Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Becker CLA 2012-01-19 12:05:39 EST 
Build Identifier: 

DoSFilterTest.testEvenLowRateIp() and DoSFilterTest.testMultipleSessionTracking() seem to fail intermittently on MacOs and thus break the build.

Reproducible: Always
Comment 1 Jesse McConnell CLA 2012-01-19 12:12:48 EST 
also in CloseableDoSFilterTest
Comment 2 Thomas Becker CLA 2012-01-30 06:40:08 EST 
Created attachment 210259 [details]
proposed patch

.testEvenLowRateIP() was failing intermittently as well. But right now I can't seem to be able to reproduce it anymore. Even running the same test 100 times didn't cause a failure. So I fixed .testMultipleSessionTracking().

Problem was a timing issue. With a sleep of 550ms after the first request burst it sometimes happened that the 6th request with sessionId1 didn't make it into DoSFilter.RateTracker within 1000ms.
Comment 3 Jesse McConnell CLA 2012-02-22 09:03:31 EST 
i had actually applied your numbers change back when we had discussed this on irc so I think this is gtg