Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369043 - [historyView] Also show submitted-at date in History view
Summary: [historyView] Also show submitted-at date in History view
Status: REOPENED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 372637 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-19 04:17 EST by Dani Megert CLA
Modified: 2012-07-23 09:15 EDT (History)
3 users (show)

See Also:

Attachments
Picture of History view (18.50 KB, image/png)
2012-01-19 04:17 EST, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2012-01-19 04:17:10 EST 
The History view shows the author date. This is not very helpful to track what happened in a branch. More interesting for that would be the submitted-at date.

See attached picture to see the confusion.
Comment 1 Dani Megert CLA 2012-01-19 04:17:59 EST 
Created attachment 209728 [details]
Picture of History view
Comment 2 Markus Keller CLA 2012-01-20 06:55:52 EST 
+1. The author date is only interesting for archeology, but the commit date is what determines the state of the repository.
Comment 3 Kevin Sawicki CLA 2012-02-24 20:40:50 EST 
Proposed fix pushed to https://git.eclipse.org/r/#/c/5165/
Comment 4 Matthias Sohn CLA 2012-02-25 18:38:54 EST 
merged as 9066219c8c172cf1696ddffc6e8ac15a70e4cb07
Comment 5 Dani Megert CLA 2012-02-27 05:45:01 EST 
Thanks Kevin and Matthias!

Verified in 2.0.0.201202261814.
Comment 6 Dani Megert CLA 2012-02-28 03:18:40 EST 
While writing another comment in bug 372637 I realized that my original enhancement request is not fixed: the fix shows the COMMITTER date but what I'm really interested in is the date and the person who pushed the commit into the shared/live repository i.e. the real committer with the appropriate permission. In Git speech this is the submitted-by and submitted-at information.
Comment 7 Dani Megert CLA 2012-02-28 03:26:17 EST 
If bug 372637 would get fixed by Gerrit, then I guess I could live with the current solution.
Comment 8 Dani Megert CLA 2012-03-02 03:42:22 EST 
We could make those two columns either optional or depending on whether Gerrit is configured on the repository.
Comment 9 Matthias Sohn CLA 2012-06-04 02:08:32 EDT 
If a change went through Gerrit and Gerrit review note is available we could display the following additional information from the review note as additional optional columns in the history view:
- Submitted-at
- Submitted-by
and maybe also the review votings (the voting categories are configurable on the Gerrit server)
- Code-Review+2
- Verified+1
Comment 10 Dani Megert CLA 2012-07-23 08:40:38 EDT 
(In reply to comment #9)
> If a change went through Gerrit and Gerrit review note is available we could
> display the following additional information from the review note as additional
> optional columns in the history view:
> - Submitted-at
> - Submitted-by
> and maybe also the review votings (the voting categories are configurable on
> the Gerrit server)
> - Code-Review+2
> - Verified+1

+1, but it should be possible to choose each optional column individually, otherwise I'd only want Submitted-at and Submitted-by.
Comment 11 Dani Megert CLA 2012-07-23 08:42:41 EDT 
*** Bug 372637 has been marked as a duplicate of this bug. ***