Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369023 - NullPointerException when tracing in org.eclipse.ecf.core.util.Trace#catching
Summary: NullPointerException when tracing in org.eclipse.ecf.core.util.Trace#catching
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 00:22 EST by Richard Huddleston CLA
Modified: 2012-02-06 02:34 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Huddleston CLA 2012-01-19 00:22:58 EST 
Build Identifier: ECF Version:  3.5.2.v20110829-0349

this method dies with an NPE if throwable is null

public static void catching(String pluginId, String option, Class clazz,
			String methodName, Throwable throwable) {

		if (shouldTrace(pluginId, option)) {
			if (throwable != null) {
				...
			}
...
			throwable.printStackTrace(System.err);
		}
	}

Reproducible: Always

Steps to Reproduce:
Enable tracing, do crazy stuff like me.

code looks to still be in latest

http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/tree/framework/bundles/org.eclipse.ecf.identity/src/org/eclipse/ecf/core/util/Trace.java
Comment 1 Markus Kuppe CLA 2012-01-19 01:29:09 EST 
Fixed in git commit d9aca990075799b78f6bda6fccb0b6e44422212b (http://git.eclipse.org/c/ecf/org.eclipse.ecf.git/commit/?id=d9aca990075799b78f6bda6fccb0b6e44422212b)
Comment 2 Markus Kuppe CLA 2012-01-19 01:29:23 EST 
foo
Comment 3 Markus Kuppe CLA 2012-01-19 22:10:01 EST 
Correct me if I'm wrong, but I don't think this one needs the iplog flag set.
Comment 4 Scott Lewis CLA 2012-01-20 12:03:38 EST 
(In reply to comment #3)
> Correct me if I'm wrong, but I don't think this one needs the iplog flag set.

It does not.  Flag cleared.
Comment 5 Wim Jongman CLA 2012-02-05 06:20:05 EST 
I am confused about this flag setting. My understanding is that an accepted patch from contributors requires the +iplog flag.
Comment 6 Scott Lewis CLA 2012-02-05 18:05:13 EST 
(In reply to comment #5)
> I am confused about this flag setting. My understanding is that an accepted
> patch from contributors requires the +iplog flag.

There was no patch, just the bug report from Richard.  The fix was identified and committed by Markus...who is a committer on the project...so there's nothing to review.
Comment 7 Wim Jongman CLA 2012-02-06 02:34:50 EST 
> There was no patch, just the bug report from Richard.  The fix was identified

I must have been blind.