Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369012 - [expr] Modifying a variable value using cell editor is not reflected in view.
Summary: [expr] Modifying a variable value using cell editor is not reflected in view.
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 18:06 EST by Pawel Piech CLA
Modified: 2013-01-10 14:18 EST (History)
2 users (show)

See Also:

Attachments
patch for this bug (1.67 KB, patch)
2012-08-22 22:22 EDT, Samrat Dhillon CLA 		Michael_Rennie: iplog+
Michael_Rennie: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2012-01-18 18:06:26 EST 
Version: 3.8.0
Build id: I20120103-0800

If I add an expression to the Expressions view, which has child element.  Then I modify the value of that child element using the cell editor.  The cell editor accepts the new value but does not refresh.  If I switch focus to another view and come back to the expressions view, the new value is shown.  

The same use case works correctly in Variables view.
Comment 1 Michael Rennie CLA 2012-01-23 13:00:52 EST 
Confirmed the problem, which existed in 3.7 and 3.6.

Wonder if it is related to bug 368276.
Comment 2 Samrat Dhillon CLA 2012-08-22 22:22:36 EDT 
Created attachment 220177 [details]
patch for this bug

Modified ExpressionEventHandler to also handle events with source as IVariable (not just IExpression). DefaultExpressionModelProxy is already handling events with source as IVariable, but ExpressionEventHandler  was not handling events from IVariable.
Comment 3 Michael Rennie CLA 2013-01-10 14:12:39 EST 
Comment on attachment 220177 [details]
patch for this bug

Patches works nicely, thanks Samrat