Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 369006 - Remove 4.x workbench dependency on equinox.concurrent
Summary: Remove 4.x workbench dependency on equinox.concurrent
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M5   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 16:06 EST by John Arthorne CLA
Modified: 2013-05-07 04:48 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2012-01-18 16:06:30 EST 
There are some trivial references to org.eclipse.equinox.concurrent in org.eclipse.e4.ui.workbench and org.eclipse.e4.core.services. I think we should just remove these rather than bringing in a new dependency. They are used to define and register a ISchedulingExecutor service but nobody ever uses it.

The reason I think it is worth removing them is this was investigation that was started long ago but never made much progress. The org.eclipse.e4.core.services.work package is in a similar state, and defines its own Future API that duplicates the work in org.eclipse.equinox.concurrent (and java.util.concurrent for that matter). Once we add a bundle to our RCP feature it is quite difficult to remove in the future.

I have a patch ready but was wondering if anyone else has seen evidence of ISchedulingExecutor being used by anyone.
Comment 1 Lars Vogel CLA 2012-01-18 16:12:20 EST 
+1 for removal
Comment 2 Brian de Alwis CLA 2012-01-18 16:49:40 EST 
It wasn't listed by Eric in his list of exported services.  I've never used it nor seen it in use.
Comment 3 John Arthorne CLA 2012-01-18 16:56:15 EST 
Thanks Brian and Lars. I believe this was an attempt to make a "20 things" abstraction of the core jobs API. However at this point it is essentially a single "schedule" method, which might be useful in some narrow cases but I'm sure isn't rich enough for real application use. Rather than confuse people with yet another API appearing to do the same thing I think it's better to remove it for now. The idea of a simplified API is fine but we would have to port some real applications to use it to prove that it is actually useful. Perhaps for a future release...
Comment 5 David Williams CLA 2012-01-24 15:36:02 EST 
If it helps ... in I20120123-2200 I still see the equinox.concurrent bundle is part of 4.2 deliverable (which I assume is expected) but "manually" confirmed in MANIFEST.MF it is no longer required by org.eclipse.e4.ui.workbench and org.eclipse.e4.core.services.