Community
Participate
Working Groups
Orion HEAD 2012-01-18 I'm seeing that visiting the Orion navigator (/navigate/table.html) starts a big chain of module loads which eventually pulls in editor.js and all its related files (contentAssist.js, textView.js, etc.). The editor and navigator should be separate.
The dependency chain is: table -> searchClient -> searchExplorer -> compare-container -> editor
hmmm...so we need to make searchClient more encapsulated. Why don't we have this problem on every single page with the search box? Simon, thoughts? Do we need to make the search client a plug-in, would that help to hide its implementation?
(In reply to comment #2) > hmmm...so we need to make searchClient more encapsulated. > Why don't we have this problem on every single page with the search box? Actually... we do. Sites, Repositories, Settings and Plugins all have the same issue.
(In reply to comment #2) > Simon, thoughts? Do we need to make the search client a plug-in, would that > help to hide its implementation? I think it should be possible to break searchClient.js into two modules. It currently has two roles: 1) Generating queries and performing search 2) Rendering search results Most clients need 1), but not 2). But 2) is what pulls in all the dependencies.
I'll take a look at this.
Fixed with: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3564db88ae52c5589cb1622434cf728e8daff6ff This was fairly straight-forward once all the dependencies were unraveled. We already have a searchResults.js script that has the job of rendering search results on the search results page. I moved all code from searchClient.js related to "complex" search result rendering into that script. I.e., the representation of search results that uses the search explorer widget that refers to the editor. What's left in searchClient is used by the global banner and other pages like the editor which need to perform searches but with "simple" search results list (Open Resource, and Ctrl+H search in editor). For these cases we don't need to pull in the search explorer widget (and hence the editor).
Verified in I20120123-2230. The built-navigator.js went from 841KB yesterday to 523KB today.
