Community
Participate
Working Groups
I think that we should handle image comparisons somehow in .4. I think that side-by-side compare view could show two versions next to each other but I'm not sure what the inline compare view could do. Maybe just show the new version of the image? I wonder if jsDiff.js can help us here? I'm attaching a screenshot showing how image comparisons look now.
Created attachment 209688 [details] Image comparison now
I think this is a more generic problem. Comparing images might be one but do we likely have the same problem with .doc , .pdfs or other files where we might just display the binary contents?
(In reply to comment #2) > I think this is a more generic problem. Comparing images might be one but do > we likely have the same problem with .doc , .pdfs or other files where we > might just display the binary contents? I agree. Actually the scope can be wider: 1.How do we open a binary file from the navigator? Currently we are always using Orion editor for most of the cases. We should use other services or browser plugins to do so. 2.The diff presentation for non text file will be hard. But if we can resolve the issue @1, at least we can kind of render two contents in two divs(iframe? not sure)
(In reply to comment #3) > (In reply to comment #2) > > I think this is a more generic problem. Comparing images might be one but do > > we likely have the same problem with .doc , .pdfs or other files where we > > might just display the binary contents? > > I agree. Actually the scope can be wider: > 1.How do we open a binary file from the navigator? Currently we are always > using Orion editor for most of the cases. We should use other services or > browser plugins to do so. I think the approach needs to be using the open with commands. Basically we take the code that is currently in explorer-table.js and generalize it so that any method can call it. We also need to make sure the open with commands are registered. I can do this work in bug 360996.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > I think this is a more generic problem. Comparing images might be one but do > > > we likely have the same problem with .doc , .pdfs or other files where we > > > might just display the binary contents? > > > > I agree. Actually the scope can be wider: > > 1.How do we open a binary file from the navigator? Currently we are always > > using Orion editor for most of the cases. We should use other services or > > browser plugins to do so. > > I think the approach needs to be using the open with commands. Basically we > take the code that is currently in explorer-table.js and generalize it so that > any method can call it. We also need to make sure the open with commands are > registered. I can do this work in bug 360996. As the consumer of the command, I would like to require that the binary contents can be rendered in any DIV by passing the resource URI. The compare-feature that generates nested border conatiners and the compare-container are separated now. If we can have such "open with" generalization I can easily load the binary contents into the left and right DIVs without bothering compare-container.
Will be nice if we have it for 0.5 but I am not sure how hard it is, Putting to RC1 for now.
We need a generic design for binary compare. This is not reasonable for 0.5.
Triage in 2.0M1.
*** Bug 339046 has been marked as a duplicate of this bug. ***
(In reply to Szymon Brandys from comment #0) > I think that we should handle image comparisons somehow in .4. I think that > side-by-side compare view could show two versions next to each other Ok, finally we got a solution. the side by side shows two versions. > but I'mnot sure what the inline compare view could do. Maybe just show the new > version of the image? > Inline mode still show two versions of the image. The top one is the newer version and the bottom one is the older version. In between there is an "hr" dom element to separate them. Inline mode is good for small image compare, to my opinion. Pushed fix with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6968c7c4f1d22c5f46bddd417f063990158322a5.
Created attachment 237407 [details] Screen cap from git status page for the fix
