Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368973 - Unexpected DI order produces NPE during import
Summary: Unexpected DI order produces NPE during import
Status: RESOLVED FIXED
Alias: None
Product: BPMN2Modeler
Classification: SOA
Component: UI (show other bugs)
Version: future   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.0.1-M1   Edit
Assignee: Robert Brodt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 09:40 EST by Andreas Drobisch CLA
Modified: 2012-10-09 11:54 EDT (History)
0 users

See Also:
bbrodt: iplog+

Attachments
Model in error (15.04 KB, application/octet-stream)
2012-01-18 09:40 EST, Andreas Drobisch CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Drobisch CLA 2012-01-18 09:40:46 EST 
Created attachment 209679 [details]
Model in error

When importing a BPMN model which includes boundary events, the DI info for the event might be parsed before the DI info of the bpmn element it is attached to.

(see the attached model)

The Graphiti container is not existing for this parent element which will cause an NPE during the position calculation / layouting of the boundary event.

I fixed this by using a queue for the import process, to postpone the boundary event shape creation to an point where the the parent shape must have been created:

https://bitbucket.org/adrobisch/fix.eclipse.bpmn2-modeler/changeset/47dd6436f125

It would be great to see this fix, or an equivalent in the master.
Comment 1 Robert Brodt CLA 2012-01-26 10:17:19 EST 
Patch applied. Thanks Andreas!