Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368950 - Slow typing in big php files – (dltk) SelectionDispatchAction performance optimization
Summary: Slow typing in big php files – (dltk) SelectionDispatchAction performance opt...
Status: CLOSED INVALID
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 07:32 EST by Natalia Bartol CLA
Modified: 2012-01-18 11:31 EST (History)
1 user (show)

See Also:

Attachments
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread (1.67 KB, patch)
2012-01-18 07:34 EST, Natalia Bartol CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Natalia Bartol CLA 2012-01-18 07:32:52 EST 
Build Identifier: 

In org.eclipse.php.ui and org.eclipse.dltk.ui plugins
SelectionDispatchAction. selectionChanged(SelectionChangedEvent event) are responsible for enabling/disabling “Open type hierarchy”/”Open call hierarchy” based on what is currently selected in the editor. It would be good to execute those calls in non UI thread as it currently affects typing performance.


Reproducible: Always
Comment 1 Natalia Bartol CLA 2012-01-18 07:34:48 EST 
Created attachment 209673 [details]
SelectionDispatchAction.dispatchSelectionChanged() in non UI thread

SelectionDispatchAction.dispatchSelectionChanged() wrapped in non UI job.
Comment 2 Alex Panchenko CLA 2012-01-18 07:43:40 EST 
I'll give it a try.
Comment 3 Natalia Bartol CLA 2012-01-18 11:31:59 EST 
I realised that there are few classes extending SelectionDispatchAction i.e. OpenCloseWorkingSetAction with methods that requires execution in UI thread. I'll create another patch just for OpenTypeHierarchyAction/OpenCallHierarchyAction classes.