Community
Participate
Working Groups
The replace all is working now as a feature but it is still lacking a complete unit test. For the replace all unit test, we should input: 1.A string of text contents. 2. A search keyword. 3. A replace string. 4.A list of index representing checked matches where we want to apply replace string. 5.Expected replaced content. We should test on 1. The in file search generates the expected result model. 2. The "new content generation" API generates the proper content representing the replaced file.
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d8d8bbc650d9354ebc18bcd5472190c59af3e666. The code change happens purely in the js-tests folder and I confirmed that all cases passed. So I did not request a code review.