Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368774 - Allow to save patches in Workspace
Summary: Allow to save patches in Workspace
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 2.0-M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-16 16:10 EST by Tomasz Zarna CLA
Modified: 2012-02-23 11:31 EST (History)
2 users (show)

See Also:

Attachments
Create Patch wizard for CVS (24.37 KB, image/png)
2012-01-16 16:12 EST, Tomasz Zarna CLA 		no flags Details
Create Patch wizard for SVN (22.67 KB, image/png)
2012-01-16 16:12 EST, Tomasz Zarna CLA 		no flags Details
Create Patch wizard for git (16.25 KB, image/png)
2012-01-16 16:13 EST, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-01-16 16:10:46 EST 
Both Create Patch wizards for CVS and SVN allow to save a patch in Workspace. The option is missing in the git wizard.
Comment 1 Tomasz Zarna CLA 2012-01-16 16:12:05 EST 
Created attachment 209591 [details]
Create Patch wizard for CVS
Comment 2 Tomasz Zarna CLA 2012-01-16 16:12:41 EST 
Created attachment 209592 [details]
Create Patch wizard for SVN
Comment 3 Tomasz Zarna CLA 2012-01-16 16:13:09 EST 
Created attachment 209593 [details]
Create Patch wizard for git
Comment 4 Matthias Sohn CLA 2012-01-25 16:51:38 EST 
contribution from Tomasz to implement this is here
http://egit.eclipse.org/r/#/c/4971/
Comment 5 Matthias Sohn CLA 2012-01-26 16:22:17 EST 
Tomasz could you please confirm the following 3 contribution questions required
for IP review of the change http://egit.eclipse.org/r/#/c/4971/ you implemented:

1.  I authored 100% of the content I'm contributing
2.  I have the rights to contribute the content to Eclipse
3.  I'm contributing the content under the EGit project license
Comment 6 Tomasz Zarna CLA 2012-01-27 03:08:55 EST 
(In reply to comment #5)
> 1.  I authored 100% of the content I'm contributing

Can I say that if I copy-pasted the code from org.eclipse.team.cvs.ui and did some minor adjustments for EGit?
Comment 7 Matthias Sohn CLA 2012-02-17 10:43:39 EST 
merged as 7205115b9a2280ab366c75a03d0348245a4243a7
Comment 8 Matthias Sohn CLA 2012-02-17 10:44:02 EST 
change was merged
Comment 9 Dani Megert CLA 2012-02-23 11:30:47 EST 
That fix breaks patch creation, see bug 372371.