Community
Participate
Working Groups
1.3.0.201201151914. The GitDateFormatter uses the default locale to create the formats. This does not work correctly when using JRE 7 or newer where the locale got split into a FORMAT and DISPLAY locale. Hence on an English OS with German set to format dates, it now shows up with English format in the Git History view. The correct way is to use DateFormat and SimpleDateFormat constructors that don't require the locale. I can provide the fix but need to know whether it is really need to go via SystemReader.getInstance() (the current code in GitDateFormatter uses it to get the locale and that's the only place where this is done).
The main purpose of SystemReader is to provide a hook for unit testing, so "it depends", but I suggest you use SystemReader for consistency. Remember the code should work with Java 5 too.
(In reply to comment #1) > The main purpose of SystemReader is to provide a hook for unit testing, > so "it depends", but I suggest you use SystemReader for consistency. OK, but we can't use getLocale(). I had to add two new methods to get the DateFormat and the SimpleDateFormat. > Remember the code should work with Java 5 too. Yep. Pushed http://egit.eclipse.org/r/4966 for review.
Robin, can you take a look at the comments in the change and reply there? Thanks.
merged as 709cd52958e9794827496ce64971a65521ad02d1
2.0.0.201202261814.(In reply to comment #4) > merged as 709cd52958e9794827496ce64971a65521ad02d1 Thanks Matthias! Verified in 2.0.0.201202261814.
