Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368707 - [Incubator] Fix details in rwt.supplemental.fileupload
Summary: [Incubator] Fix details in rwt.supplemental.fileupload
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Incubator (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.5 M5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-16 08:11 EST by Rüdiger Herrmann CLA
Modified: 2012-01-17 11:02 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2012-01-16 08:11:08 EST 
These thinks caught my eye me when looking at the o.e.r.rwt.supplemental.fileupload bundle:
* FileUploadDetails resides in a public package without reason
* IFileUploadListener is a listener-interface and therefore should not start with an 'I'
Comment 1 Rüdiger Herrmann CLA 2012-01-16 08:29:10 EST 
One more:
The IFileUploadListener should document that it isn't called from the UI thread, or otherwise be called from the UI thread.
Comment 2 Ralf Sternberg CLA 2012-01-16 15:49:48 EST 
I agree to all of your suggestions. Regarding the UI thread, I vaguely remember that there was the problem that the listener can be called without a context available, so I think 'd prefer to document the fact that it is not called from the UI thread.
Comment 3 Ivan Furnadjiev CLA 2012-01-17 11:02:09 EST 
Fixed all remarks in CVS HEAD.