Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368704 - [sasheditor] SashEditor does not invoke dispose() of nested IEditorPart
Summary: [sasheditor] SashEditor does not invoke dispose() of nested IEditorPart
Status: CLOSED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 366943
  Show dependency tree
 
Reported: 2012-01-16 07:33 EST by Marc-Florian Wendland CLA
Modified: 2012-07-03 08:03 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Florian Wendland CLA 2012-01-16 07:33:50 EST 
When the SashEditor is closed, it does not propagate the closing request to its contained IEditorParts. Normally, (like MultiPageEditorPart) the closing request should result in invoking the IEditorPart.dipose() method of all nested IEditorParts.

This is vital for the lifecycle of widgets and bindings wihtin the nested IEditorParts. The dipose() methods is commonly used to finish/close resources ina clean way.

Allowing the IEditorParts to release shared resources is vital for the whole SashEditor and any IEditorPart that is included in the SashEditor.
Comment 1 Cedric Dumoulin CLA 2012-02-10 16:08:05 EST 
A JUnit test is added:

org.eclipse.papyrus.infra.core.sasheditor.internal.SashWindowsContainerDisposeCalledTest
Comment 2 Cedric Dumoulin CLA 2012-02-14 10:55:45 EST 
The dispose() is now called on nested editors when they are closed.
Comment 3 Cedric Dumoulin CLA 2012-07-03 08:03:32 EDT 
Bug is fixed