Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368698 - GenerateJsp.emtl is missing in org.eclipse.modisco.jee.jsp.generation.
Summary: GenerateJsp.emtl is missing in org.eclipse.modisco.jee.jsp.generation.
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.1   Edit
Hardware: All All
: P2 blocker (vote)
Target Milestone: 0.9.2 RC1   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-16 06:29 EST by Gregoire Dupe CLA
Modified: 2013-05-02 05:04 EDT (History)
3 users (show)

See Also:
gdupe: indigo+
gdupe: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2012-01-16 06:29:08 EST 
The file GenerateJsp.emtl is missing in org.eclipse.modisco.jee.jsp.generation_0.9.1.v201109150824.jar
Comment 1 Nicolas Bros CLA 2012-01-16 11:24:40 EST 
Fixed on trunk in revision 4786 and on branch 0_1 in revision 4787.

I'm leaving this bug open until both Hudson jobs have passed and contain the emtl files.
Comment 2 Nicolas Bros CLA 2012-01-16 12:48:39 EST 
The emtl file was not copied to the right directory (it was copied to a gmt folder which did not exist anymore).
Fixed on trunk in 4788 and on branch 0_9 in 4789.
Comment 3 Nicolas Bros CLA 2012-01-17 03:50:45 EST 
Now the emtl file is not copied *from* the right directory. Fixed in 4790 & 4791 on branch and 4792 & 4793 on trunk.
Comment 4 Nicolas Bros CLA 2012-01-17 08:41:15 EST 
The last modisco-nightly build contains the file:
org/eclipse/modisco/jee/jsp/generation/files/GenerateJsp.emtl
in org.eclipse.modisco.jee.jsp.generation_0.10.0.v201201171052.jar

The branch build remains to be tested.
Comment 5 Nicolas Bros CLA 2012-01-17 10:18:09 EST 
The latest modisco-nightly-maintenance build also contains the emtl file.

Now we need to make sure that this regression is caught by unit tests.
This unit test was supposed to test the JSP generator, but it succeeded even though the emtl file was not present. So it must be fixed:
org.eclipse.modisco.jee.jsp.generation.tests.DiffGeneratedJspTest
Comment 6 Nicolas Bros CLA 2012-01-17 11:05:00 EST 
When I delete the emtl file and I run the test locally, the JUnit test fails as expected:
java.io.IOException: '/org/eclipse/modisco/jee/jsp/generation/files/GenerateJsp.emtl' not found

I don't understand why it did not fail in the same way on Hudson. Maybe it is due to a different version of Acceleo.

So, I added a new test that tests specifically for the presence of the emtl file in revision 4794 on trunk and in revision 4795 on branch 0_9.
Comment 7 Hugo Bruneliere CLA 2012-05-29 08:35:49 EDT 
Issue solved and tested.