Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368587 - orion.edit.command gets selection wrong when plugin returns text
Summary: orion.edit.command gets selection wrong when plugin returns text
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 15:31 EST by Susan McCourt CLA
Modified: 2012-01-13 15:32 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-01-13 15:31:36 EST 
the code for orion.edit.command says that if you return only text, it will replace the selection with your text.  It gets the text part correct, but it keeps the editor selection at the same positions as originally. 

For example I wrote a plugin that replaces 191,191,191 with #bfbfbf and the selection ends up containing my returned text plus a few characters after (the selection length remains the same).
Comment 1 Susan McCourt CLA 2012-01-13 15:32:35 EST 
fixed.  Also fixed a bug where the editor keybinding was failing for contributed commands.