Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 368580 - Refactor IDE runtime dependencies
Summary: Refactor IDE runtime dependencies
Status: RESOLVED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: tooling (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Miles Parker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 368890
  Show dependency tree
 
Reported: 2012-01-13 14:16 EST by Miles Parker CLA
Modified: 2012-01-17 19:49 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Parker CLA 2012-01-13 14:16:34 EST 
Currently virgo.ide.runtime.ui has dependencies on org.eclipse.mylyn internals as well as zest. We should replace the mylyn internals (CommonImage) usage and factor zest into a seperate plugin.

The Zest dependendency should also probably be in a seperate optional feature, but we might handle that under another bug.
Comment 1 Miles Parker CLA 2012-01-17 19:03:35 EST 
Fixed, ridiculously easy. My official first Virgo contribution, assuming that -3 lines counts.

1) I have approval to submit this code
2) I (un-)wrote all of this code.

https://github.com/MilesParker/Virgo-Tooling/commit/a0323a289b74cfa8d7d9337556e148dd0ce909d1
Comment 2 Leo Dos Santos CLA 2012-01-17 19:33:36 EST 
Thanks Miles. Looks like the dependencies went away with the Libra contribution. You can view the checkin at http://git.eclipse.org/c/virgo/org.eclipse.virgo.ide.git/commit/?id=b6203008a2c2799d9eedbfc02acbf03537da521a

One note, I think it's best practice to keep the bug open until the committer has had the chance to merge the change in. Aside from that, congratulations on your first contribution to Virgo!
Comment 3 Miles Parker CLA 2012-01-17 19:49:15 EST 
Yeah, I had that realization about closing the bug and meant to correct but then promptly forgot it.